Skip to content

Conversation

@Inode1
Copy link
Contributor

@Inode1 Inode1 commented Jan 18, 2026

What this PR does / why we need it:

Currently, Envoy supports JAX fingerprinting via the TLS Inspector listener filter using the enable_jaX_fingerprinting option.

EG does not currently expose a way to enable this setting through high-level APIs like ClientTrafficPolicy or equivalent constructs.

New optin field in CTP:

spec.tls.enableFingerprint: true

Which issue(s) this PR fixes:
Fixes ##7916

Release Notes: Yes

@Inode1 Inode1 requested a review from a team as a code owner January 18, 2026 11:41
@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 4a0d398
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696e66fdfa36c300089aeea6

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.89%. Comparing base (d0f72f6) to head (4a0d398).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/listener.go 78.26% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7983      +/-   ##
==========================================
+ Coverage   72.82%   72.89%   +0.07%     
==========================================
  Files         237      237              
  Lines       35475    35544      +69     
==========================================
+ Hits        25835    25911      +76     
+ Misses       7801     7794       -7     
  Partials     1839     1839              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Inode1 Inode1 force-pushed the feat-jaX-fingerprint-support branch 2 times, most recently from d2cb643 to 7cd21d8 Compare January 18, 2026 12:25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add an e2e for this?

@Inode1 Inode1 changed the title feat jaX fingerprint support feat: jaX fingerprint support Jan 18, 2026
@Inode1 Inode1 force-pushed the feat-jaX-fingerprint-support branch from 7cd21d8 to 4a9a9c6 Compare January 19, 2026 17:15
Signed-off-by: i.makarychev <makarichev.ivan@gmail.com>
Signed-off-by: i.makarychev <i.makarychev@tbank.ru>
@Inode1 Inode1 force-pushed the feat-jaX-fingerprint-support branch from 4a9a9c6 to 4a0d398 Compare January 19, 2026 17:16
@Inode1
Copy link
Contributor Author

Inode1 commented Jan 19, 2026

is it possible to add an e2e for this?

I think so, it will take some more time.

// forwarded to upstream services using request headers.
//
// +optional
EnableFingerprint *bool `json:"enableFingerprint,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this should be a struct to selectively enable different types of JAX fingerprints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants