-
Notifications
You must be signed in to change notification settings - Fork 647
feat: jaX fingerprint support #7983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7983 +/- ##
==========================================
+ Coverage 72.82% 72.89% +0.07%
==========================================
Files 237 237
Lines 35475 35544 +69
==========================================
+ Hits 25835 25911 +76
+ Misses 7801 7794 -7
Partials 1839 1839 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d2cb643 to
7cd21d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
zirain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add an e2e for this?
7cd21d8 to
4a9a9c6
Compare
Signed-off-by: i.makarychev <makarichev.ivan@gmail.com> Signed-off-by: i.makarychev <i.makarychev@tbank.ru>
4a9a9c6 to
4a0d398
Compare
I think so, it will take some more time. |
| // forwarded to upstream services using request headers. | ||
| // | ||
| // +optional | ||
| EnableFingerprint *bool `json:"enableFingerprint,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo this should be a struct to selectively enable different types of JAX fingerprints
What this PR does / why we need it:
Currently, Envoy supports JAX fingerprinting via the TLS Inspector listener filter using the enable_jaX_fingerprinting option.
EG does not currently expose a way to enable this setting through high-level APIs like ClientTrafficPolicy or equivalent constructs.
New optin field in CTP:
spec.tls.enableFingerprint: trueWhich issue(s) this PR fixes:
Fixes ##7916
Release Notes: Yes