Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Jan 19, 2026

fixes: #7947

I'm not sure if this worked on every cases, so users're able to fallback to use server.total_connections with following:

apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
  name: eg-with-ep
spec:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
  parametersRef:
    group: gateway.envoyproxy.io
    kind: EnvoyProxy
    name: proxy-config
    namespace: envoy-gateway-system
---
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: eg-with-ep
spec:
  gatewayClassName: eg-with-ep
  listeners:
    - name: http
      protocol: HTTP
      port: 80
---
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: proxy-config
  namespace: envoy-gateway-system
spec:
  provider:
    type: Kubernetes
    kubernetes:
      envoyDeployment:
        patch:
          type: StrategicMerge
          value:
            spec:
              template:
                spec:
                  containers:
                    - name: shutdown-manager
                      env:
                        - name: "USE_SERVER_CONNECTIONS"
                          value: "true"

…culation

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner January 19, 2026 04:37
@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 2e002c6
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696de1d3fde40900093f3ccf
😎 Deploy Preview https://deploy-preview-7985--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zirain zirain changed the title feat: Ignore ready and stats listener metrics in shutdown manager cal… feat: Ignore ready and stats listener metrics in shutdown manager calculation Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.87%. Comparing base (b28b77c) to head (2e002c6).

Files with missing lines Patch % Lines
internal/cmd/envoy/shutdown_manager.go 69.23% 13 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7985   +/-   ##
=======================================
  Coverage   72.87%   72.87%           
=======================================
  Files         237      237           
  Lines       35509    35534   +25     
=======================================
+ Hits        25877    25896   +19     
- Misses       7792     7793    +1     
- Partials     1840     1845    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore ready and stats listener metrics in shutdown manager calculation

1 participant