-
Notifications
You must be signed in to change notification settings - Fork 3
Add API changelog where provided #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bars. This ended up being quite a complex job, especially to get the styling right and scrolling to function correctly.
It's possible to use module version, but maybe not preferable right now
Add call to changelog script in build process.
Processing filtered based on existance of changelog file on build. Dyanmically generate insance of changelog plugin for each changelog present.
anttiviljami
approved these changes
May 15, 2025
Member
anttiviljami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the build process to download API changelogs, processes them, and then dispalys them, for each API.
API services must have created and pushed a changelogs to the required S3 bucket.
CI will automatically generated the changelogs, while an API's publish OAD script will need updating to also publish the related changelog files to the same S3 bucket.