feat(materials): implement comprehensive material system (#47) #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a complete material system aligned with SAA/CLAD architecture. This PR introduces universal material types in the core and corresponding WGSL shaders in the sandbox, establishing the foundation for the rendering pipeline.
Key Changes:
Material Types (
khora-core/src/asset/materials/):Opaque,Mask, andBlendtransparency modes.WGSL Shaders (
examples/sandbox/assets/shaders/):standard_pbr.wgsl: Cook-Torrance BRDF with Fresnel-Schlick.emissive.wgsl: HDR emissive handling with tone mapping.wireframe.wgsl: Edge detection using barycentric coordinates.unlit.wgsl: Simplified shader for sandbox compatibility.Architecture:
khora-core.RenderAgent.Closes [Feature] Implement Material System #47
Type of change
Please check the boxes that apply or delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce, if applicable. Please also list any relevant details for your test configuration.
Test Configuration (if relevant for manual testing):
Checklist:
Before submitting your pull request, please make sure you have completed the following:
cargo fmt --all -- --checklocally and it passes.cargo clippy --workspace --all-targets --all-features -- -D warningsand there are no new clippy warnings.cargo test --workspace --all-targets --all-features).Screenshots (if applicable)
N/A
Further comments or questions for the reviewer
Full shader integration and pipeline selection will be implemented in issue #48 (Basic Lighting Models). This PR focuses on the data structures and shader logic foundations.