Python - MTLS Changes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara-kiss
reviewed
Jun 17, 2025
| raise LoginError(f"Login failed ({exception})") from exception | ||
| return response.content | ||
|
|
||
| def read_file(path): |
Contributor
There was a problem hiding this comment.
should this be a separate function when it's only used once?
Contributor
Author
There was a problem hiding this comment.
this can be moved inside.
surendarraju
commented
Jun 19, 2025
Contributor
Author
There was a problem hiding this comment.
Looks good to me
mihai-bocioroaga
previously approved these changes
Jun 19, 2025
mihai-bocioroaga
previously approved these changes
Jun 26, 2025
Harishankar-Ericsson
requested changes
Jun 27, 2025
charts/eric-oss-hello-world-python-app/templates/deployment/deployment.yaml
Show resolved
Hide resolved
mihai-bocioroaga
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.