-
Notifications
You must be signed in to change notification settings - Fork 3
Added mTLS support for endpoints #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will replace the app name to original namewq
Configmap name changed httpport -> http-port httpsport -> https-port e
mihai-bocioroaga
requested changes
Aug 21, 2025
charts/eric-oss-hello-world-python-app/templates/deployment/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/eric-oss-hello-world-python-app/templates/deployment/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/eric-oss-hello-world-python-app/templates/deployment/deployment.yaml
Outdated
Show resolved
Hide resolved
Closed
don2112e
reviewed
Aug 25, 2025
charts/eric-oss-hello-world-python-app/templates/configmap/envoy-configmap.yaml
Outdated
Show resolved
Hide resolved
surendarraju
commented
Aug 26, 2025
surendarraju
commented
Aug 26, 2025
surendarraju
commented
Aug 26, 2025
surendarraju
commented
Aug 26, 2025
surendarraju
commented
Aug 26, 2025
Contributor
Author
|
Reopening... the PR issues will be addressed... |
kara-kiss
requested changes
Aug 27, 2025
This details is required to identify the product rather envoy itself
Removed tutorial commands from README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes,
1). Mounting the App(Server) and EIC(Client)
2). Envoy acts as sidecar to handle mTLS termination
3). Individual docker files for App and Envoy
4). Docker Compose file
5). Eric product info details