-
Notifications
You must be signed in to change notification settings - Fork 144
fixes to compile under Erlang 17.0-rc2 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified files with Oscar Hellström's name to be UTF-8 Started asn1 before public_key in eunit tests
|
👍 |
1 similar comment
|
+1 |
|
Even with this, I get: when installing with rebar. |
Contributor
Author
|
@radekg are you sure you're using my branch? Your error is coming from the 'deps/' directory and Rebar would normally pull from master. |
|
Ah, no, apologies. It was late here. It works now. |
|
pretty please? |
Member
|
Here I have a fork of this project that has this merged in: https://github.com/lastres/lhttpc |
g-andrade
pushed a commit
to g-andrade/lhttpc
that referenced
this pull request
Nov 26, 2014
Basic multipart upload support
elbrujohalcon
pushed a commit
that referenced
this pull request
Sep 28, 2015
fixes to compile under Erlang 17.0-rc2
|
Thanks @elbrujohalcon @sstrigler ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified files with Oscar Hellström's name to be UTF-8. This stops the compiler from choking on the file. Fixes #42 and fixes #35
Added a
application:start(asn1)before public_key in eunit tests. This was causing some test failures.With these changes, lhttpc compiles and passes all tests for me under Erlang 17.0-rc2 on Mac OS X 10.9.2.