Skip to content

Conversation

@waisbrot
Copy link
Contributor

Modified files with Oscar Hellström's name to be UTF-8. This stops the compiler from choking on the file. Fixes #42 and fixes #35

Added a application:start(asn1) before public_key in eunit tests. This was causing some test failures.

With these changes, lhttpc compiles and passes all tests for me under Erlang 17.0-rc2 on Mac OS X 10.9.2.

Modified files with Oscar Hellström's name to be UTF-8
Started asn1 before public_key in eunit tests
@av-ast
Copy link

av-ast commented Mar 27, 2014

👍

1 similar comment
@jflatow
Copy link

jflatow commented Mar 28, 2014

+1

@radekg
Copy link

radekg commented Aug 2, 2014

Even with this, I get:

ERROR: Failed to extract name from deps/lhttpc/src/lhttpc.app.src: {27,
                                                                                 file_io_server,
                                                                                 invalid_unicode}

when installing with rebar.

@waisbrot
Copy link
Contributor Author

waisbrot commented Aug 3, 2014

@radekg are you sure you're using my branch? Your error is coming from the 'deps/' directory and Rebar would normally pull from master.

@radekg
Copy link

radekg commented Aug 3, 2014

Ah, no, apologies. It was late here. It works now.

@ypaq
Copy link

ypaq commented Oct 14, 2014

pretty please?

@lastres
Copy link
Member

lastres commented Oct 15, 2014

Here I have a fork of this project that has this merged in: https://github.com/lastres/lhttpc

g-andrade pushed a commit to g-andrade/lhttpc that referenced this pull request Nov 26, 2014
Basic multipart upload support
@waisbrot
Copy link
Contributor Author

I see we've added PRs #44 #45 #49 and #54 all alternatives to fix the same bug but none merged or closed...

elbrujohalcon pushed a commit that referenced this pull request Sep 28, 2015
fixes to compile under Erlang 17.0-rc2
@elbrujohalcon elbrujohalcon merged commit 6530ef8 into esl:master Sep 28, 2015
@andreineculau
Copy link

Thanks @elbrujohalcon @sstrigler ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lhttpc does not work in Erlang Release 17

8 participants