-
Notifications
You must be signed in to change notification settings - Fork 179
French politeness #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French politeness #207
Conversation
…w things to still adjust
Used "propagate_case : true" & "word : true" to ensure correct behavior. Removed Utils as there were no relations to the current package. Updated ReadMe accordingly.
smeech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
A package of simple trigger/replace pairs with a couple of forms. No script or shell or potentially malicious code.
I've left a few comments for you to consider.
I'll let CoPilot review and run the CI checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a new Espanso package for French politeness expressions, providing text expansion shortcuts for common French greetings, salutations, and formal expressions. The package includes comprehensive configuration, documentation, and metadata files.
Key changes:
- Added French politeness package with 26 text expansion triggers for opening and closing expressions
- Implemented case propagation and word boundary detection for natural text replacement
- Included interactive forms for customizable greetings (
:cherand:alattde)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/french-politeness/0.1.0/package.yml | Core espanso configuration defining 26 French expression triggers with case propagation and interactive forms |
| packages/french-politeness/0.1.0/_manifest.yml | Package metadata including author, version, description, and tags |
| packages/french-politeness/0.1.0/README.md | Complete documentation with usage instructions, trigger tables, and feature descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated README in accordance to PR comments.
Updated package.yml in accordance to PR comments.
|
Thanks a lot for your review ! |
Implemented the french-politeness package