Skip to content

Conversation

@sigmaaa
Copy link
Collaborator

@sigmaaa sigmaaa commented Jan 19, 2026

Description

fixed this issue:
image

Fixes # (IEP-1677)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Bug Fixes
    • Fixed href attribute formatting in partition size messages for proper link rendering.

✏️ Tip: You can customize this high-level summary in your review settings.

@sigmaaa sigmaaa self-assigned this Jan 19, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

A single-line modification to a properties file updates the IncreasePartitionSizeMessage href attribute, changing the placeholder from unquoted {2} to quoted "{2}".

Changes

Cohort / File(s) Summary
Message Properties Update
bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/messages.properties
Modified href attribute in IncreasePartitionSizeMessage to quote the placeholder value {2}

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • kolipakakondal
  • AndriiFilippov

Poem

🐰 A quote wrapped round a tiny brace,
Makes messages shine with proper grace,
One line changed, precision gained,
In properties where values reigned!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: fixing a notification link display issue in the Low App Partition Size message, matching the actual code change (href attribute quoting fix).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AndriiFilippov
Copy link
Collaborator

@sigmaaa hi !

Tested under:
OS: Windows 11 / Mac arm64
ESP-IDF: v5.5.2
Screenshot 2026-01-20 at 17 21 54

issue fixed. link works as expected ✅
LGTM 👍

Copy link
Collaborator

@kolipakakondal kolipakakondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolipakakondal kolipakakondal added this to the v4.1.0 milestone Jan 21, 2026
@kolipakakondal kolipakakondal merged commit 1aa2a1f into master Jan 21, 2026
10 of 12 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1677 branch January 21, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants