Skip to content

Conversation

@sigmaaa
Copy link
Collaborator

@sigmaaa sigmaaa commented Jan 31, 2026

Description

Upgrade core editing dependencies in com.espressif.idf.target to support the new CDT-LSP 3.4 features, ensure API compatibility, and improve syntax highlighting performance for large files.

Fixes # (IEP-1689)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated IDE development tool dependencies and repositories to newer versions for improved language support and debugging capabilities.
    • Added new JSON-RPC debugging component.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

This pull request updates the Eclipse IDE target definition file to reference newer versions of several p2 repositories and installable units, including tm4e, cdt-lsp, lsp4e, and snakeyaml, while introducing placeholder versions for certain lsp4e and lsp4j units.

Changes

Cohort / File(s) Summary
Eclipse Target Definition Updates
releng/com.espressif.idf.target/com.espressif.idf.target.target
Updated p2 repository URLs for tm4e (0.15.1 → 0.17.1), cdt-lsp (3.3.0 → 3.4.0), and lsp4e (0.29.3 → 0.29.5). Bumped org.yaml.snakeyaml from 2.2.0 to 2.5.0. Changed org.eclipse.lsp4e and org.eclipse.lsp4e.debug to version 0.0.0 placeholders. Added new org.eclipse.lsp4j.jsonrpc.debug unit at 0.0.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • kolipakakondal
  • AndriiFilippov
  • alirana01

Poem

🐰 With repositories fresh and units aligned,
Eclipse dependencies now refined,
TM4E hops to 0.17.1's call,
LSP4E learns to dance it all,
Our IDE toolchain stands ever tall! 🎯

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating three Eclipse p2 repository dependencies (CDT-LSP, LSP4E, TM4E) to specific versions, which aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch IEP-1689

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@kolipakakondal kolipakakondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolipakakondal kolipakakondal added this to the v4.1.0 milestone Feb 2, 2026
@AndriiFilippov
Copy link
Collaborator

AndriiFilippov commented Feb 2, 2026

@sigmaaa hi !

Tested under:
OS: Windows 11 / Mac ARM64
ESP-IDF: v5.5.2
EIM_GUI: release/v0.7.0
Eclipse: 25-12

CDT-LSP completion + navigation works ✅
Syntax highlighting correct ✅
No new errors in Error Log ✅
Build/flash unaffected ✅

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants