-
Notifications
You must be signed in to change notification settings - Fork 133
IEP-1689 Update Target Platform dependencies: CDT-LSP 3.4, LSP4E 0.29.5, TM4E 0.17.1 #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request updates the Eclipse IDE target definition file to reference newer versions of several p2 repositories and installable units, including tm4e, cdt-lsp, lsp4e, and snakeyaml, while introducing placeholder versions for certain lsp4e and lsp4j units. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kolipakakondal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@sigmaaa hi ! Tested under: CDT-LSP completion + navigation works ✅ LGTM 👍 |
Description
Upgrade core editing dependencies in com.espressif.idf.target to support the new CDT-LSP 3.4 features, ensure API compatibility, and improve syntax highlighting performance for large files.
Fixes # (IEP-1689)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.