Skip to content

Conversation

@thyttan
Copy link
Collaborator

@thyttan thyttan commented Jan 17, 2026

Try the change on my app loader: https://thyttan.github.io/BangleApps/?id=smpltmr

Tagging @peerdavid and @sir-indy as previous authors for feedback.

thyttan added 5 commits January 17, 2026 16:05
I didn't manage to make an ideal solution. In my mind one step of either
hour, minute or second indicator should correspond to one buzz. One can
look to e.g. the dial module for inspiration. But I didn't want to
change the logic too much for now at least.
@thyttan thyttan changed the title Smpltmr: Fix trigger happy buzzing smpltmr: Fix trigger happy buzzing Jan 17, 2026
Copy link
Collaborator

@bobrippling bobrippling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will wait for the others you've tagged, but perhaps a small suggestion to explain what's causing the extra buzzing?

@peerdavid
Copy link
Contributor

Just a quick comment - I had a really really great time developing for the BangleJs but I recently moved to Pebble (something I always wanted to try as well) Therefore, I'm no more developing for the BangleJs. So for me any improvements and fixes are fine but I can no more contribute :)

@RKBoss6
Copy link
Contributor

RKBoss6 commented Jan 21, 2026

Tried it out and it looks good! One suggestion - currently when you drag, it increments in large values (drag once and it goes from 3--> 17). Is it possible for you fix this to be more like the show menu pickers where they increment predictably, as it'll tie into removing extra buzzes?

@thyttan
Copy link
Collaborator Author

thyttan commented Jan 21, 2026

One suggestion - currently when you drag, it increments in large values (drag once and it goes from 3--> 17). Is it possible for you fix this to be more like the show menu pickers where they increment predictably, as it'll tie into removing extra buzzes?

Yes, I added a comment to this commit 66e5e21

I didn't manage to make an ideal solution. In my mind one step of either
hour, minute or second indicator should correspond to one buzz. One can
look to e.g. the dial module for inspiration. But I didn't want to
change the logic too much for now at least.

So while it shouldn't be too hard it wasn't trivial and requires a slightly bigger rewrite. Which I didn't want to do now in this PR. :)

But I agree it would be nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants