-
Notifications
You must be signed in to change notification settings - Fork 1.3k
smpltmr: Fix trigger happy buzzing #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I didn't manage to make an ideal solution. In my mind one step of either hour, minute or second indicator should correspond to one buzz. One can look to e.g. the dial module for inspiration. But I didn't want to change the logic too much for now at least.
bobrippling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will wait for the others you've tagged, but perhaps a small suggestion to explain what's causing the extra buzzing?
|
Just a quick comment - I had a really really great time developing for the BangleJs but I recently moved to Pebble (something I always wanted to try as well) Therefore, I'm no more developing for the BangleJs. So for me any improvements and fixes are fine but I can no more contribute :) |
|
Tried it out and it looks good! One suggestion - currently when you drag, it increments in large values (drag once and it goes from 3--> 17). Is it possible for you fix this to be more like the show menu pickers where they increment predictably, as it'll tie into removing extra buzzes? |
Yes, I added a comment to this commit 66e5e21
So while it shouldn't be too hard it wasn't trivial and requires a slightly bigger rewrite. Which I didn't want to do now in this PR. :) But I agree it would be nice 👍 |
Try the change on my app loader: https://thyttan.github.io/BangleApps/?id=smpltmr
Tagging @peerdavid and @sir-indy as previous authors for feedback.