Improve ESTER chemistry fixing freeeos implementation#13

Open

ctmbl wants to merge 20 commits intoester-project:masterfrom

ctmbl:metal-config

Commits on Aug 23, 2023

Update intial_composition to read an hardcoded metal-mix.cfg file
ctmbl
committed
Remove old metal comp initialization (commented)
ctmbl
committed
Initialize comp object with all metals (isotopic or not) to 0
ctmbl
committed
Add a TODO
ctmbl
committed
Check that metal-mix.cfg keys are metals in a specific set and print the remaining of the sum of fractions
ctmbl
committed
Update eos_freeeos to extract metals fractions from comp and choose most import isotops
ctmbl
committed
(REVERTED LATER) Add printf to debug
ctmbl
committed
(BREAKS ESTER INFO ON PURPOSE) Call init_comp only in star*d::init not in fill/read, remove useless redondant init_comp
ctmbl
committed
TO BE EDITED Crash ester if initial_composition is called multiple times
ctmbl
committed
Remove fat old comment about Daniel's and Delphine's special star layers comp in stard::init_comp
ctmbl
committed
Add an important TODO about code moving to star*d_class.cpp
ctmbl
committed
Introduce star2d::init_metal_mix method to replace old initial_composition
ctmbl
committed
Update star2d::init_comp to use new star2d::init_metal_mix and remove old initial_composition
ctmbl
committed
Make the He3/He4 ratio a star2d attr and hardcode it in star2d::init_comp
ctmbl
committed
Add 2 matrix_map::operator() methods that uses matrix::operator()
ctmbl
committed
Fix wrongly named nuc_calc signature
ctmbl
committed
Clean src/physics/eos_opal.cpp, removing useless code
ctmbl
committed
Change eos_* signature to pass the whole star composition
ctmbl
committed
Fix OPAL interpolation and double comparison pb
ctmbl
committed
Revert "Add printf to debug"
ctmbl
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve ESTER chemistry fixing freeeos implementation#13

Improve ESTER chemistry fixing freeeos implementation#13
ctmbl wants to merge 20 commits intoester-project:masterfrom
ctmbl:metal-config

Commits on Aug 23, 2023

Update intial_composition to read an hardcoded metal-mix.cfg file

Remove old metal comp initialization (commented)

Initialize comp object with all metals (isotopic or not) to 0

Add a TODO

Check that metal-mix.cfg keys are metals in a specific set and print the remaining of the sum of fractions

Update eos_freeeos to extract metals fractions from comp and choose most import isotops

(REVERTED LATER) Add printf to debug

(BREAKS ESTER INFO ON PURPOSE) Call init_comp only in star*d::init not in fill/read, remove useless redondant init_comp

TO BE EDITED Crash ester if initial_composition is called multiple times

Remove fat old comment about Daniel's and Delphine's special star layers comp in stard::init_comp

Add an important TODO about code moving to star*d_class.cpp

Introduce star2d::init_metal_mix method to replace old initial_composition

Update star2d::init_comp to use new star2d::init_metal_mix and remove old initial_composition

Make the He3/He4 ratio a star2d attr and hardcode it in star2d::init_comp

Add 2 matrix_map::operator() methods that uses matrix::operator()

Fix wrongly named nuc_calc signature

Clean src/physics/eos_opal.cpp, removing useless code

Change eos_* signature to pass the whole star composition

Fix OPAL interpolation and double comparison pb

Revert "Add printf to debug"

Improve ESTER chemistry fixing freeeos implementation#13ctmbl wants to merge 20 commits intoester-project:masterester-project/ester:masterfrom ctmbl:metal-configctmbl/ester:metal-configCopy head branch name to clipboard

Commits

Commits on Aug 23, 2023

Improve ESTER chemistry fixing freeeos implementation#13
ctmbl wants to merge 20 commits intoester-project:masterfrom
ctmbl:metal-config