Skip to content

Parsing update #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ctmbl wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Parsing update #18

ctmbl wants to merge 15 commits into from

Conversation

@ctmbl
Copy link
Contributor

@ctmbl ctmbl commented Feb 6, 2024

TODO

[x] Rename check_arg -> parse_arg
[x] Refactor la classe configuration

  • separer le parsing en 2 methods
  • commenter
    [ ] Refactor star1d::init:
  • separer file parsing et cmd line parsing en 2 à 3 methods
  • factoriser du code si possible
  • commenter
    [ ] Refactor star2d::init:
  • separer file parsing et cmd line parsing en 2 à 3 methods
  • factoriser du code si possible
  • séparer les check des arg nth et nex dans la méthode parse_arg si possible
  • commenter
    [ ] Homogénéiser star1d::init et star2d::init logging, parsing, logic

ctmbl added 15 commits February 6, 2024 16:36
@ctmbl
Move command line and config file parsing to a new method configurati…
8154434 
…on::read_config
@ctmbl
Seggregate config file and cmd line parsing in configuration class
cc7fe91
@ctmbl
Introduce and call configuration::read_config from main (see body)
7df9ede 
configuration::read_config wraps read_config_file and read_command_line to ensure execution order
@ctmbl
Improve file_parser::open method and configuration::read_config_file …
283ad98 
…logic and code

file_parser::open now returns 1 on error and 0 else

configuration::read_config_file has been cleared a bit:
- add some comments
- rename variables
- better logic
@ctmbl
Reorganize read_config.h
613b8bd
@ctmbl
Change indentation from tabs to 4 whitespaces
b5dd8eb
@ctmbl
Improve configuration::read_command_line readibility
8a7657c
@ctmbl
Improve src/include/parser.h readibility
681fa89
@ctmbl
Change src/include/parser.h indentation from tabs to 4 whitespaces
6a298ad
@ctmbl
Improve command_parser::get error code -1 logic
c3969de
@ctmbl
Comment read_config and parser code
9199a7d
@ctmbl
Rename check_arg --> parse_arg
ef91956
@ctmbl
Comment star*d.cpp main
1f2f367
@ctmbl
Improve star1d::init messages and consistency
1578bdb
@ctmbl
Remove useless methods of configuration class
432565a
@ctmbl ctmbl mentioned this pull request Feb 6, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ctmbl