Skip to content

Conversation

@hwdef
Copy link
Contributor

@hwdef hwdef commented Dec 11, 2025

This PR is a part of: #20270

It prepares for subsequent unit testing.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hwdef
Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.42%. Comparing base (7b1f0f2) to head (c85f68d).

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/global.go 0.00% 78 Missing ⚠️
etcdctl/ctlv3/command/make_mirror_command.go 0.00% 5 Missing ⚠️
etcdctl/ctlv3/command/ep_command.go 0.00% 4 Missing ⚠️
etcdctl/ctlv3/command/check.go 0.00% 1 Missing ⚠️
etcdctl/ctlv3/ctl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/ctlv3/command/check.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/ctl.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/ep_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/make_mirror_command.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/global.go 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21010      +/-   ##
==========================================
+ Coverage   69.21%   69.42%   +0.21%     
==========================================
  Files         422      422              
  Lines       34841    34794      -47     
==========================================
+ Hits        24114    24156      +42     
+ Misses       9328     9245      -83     
+ Partials     1399     1393       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b1f0f2...c85f68d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwdef hwdef force-pushed the optimize-etcdctl-ut branch 2 times, most recently from 5e7f02b to 3e92a81 Compare December 12, 2025 07:02
@hwdef hwdef force-pushed the optimize-etcdctl-ut branch from 3e92a81 to f37af54 Compare December 12, 2025 07:51
…lization

Signed-off-by: hwdef <hwdefcom@outlook.com>
@hwdef hwdef force-pushed the optimize-etcdctl-ut branch from f37af54 to c85f68d Compare December 12, 2025 09:19
@hwdef
Copy link
Contributor Author

hwdef commented Dec 12, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants