Skip to content

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 13, 2025

We don't have such a list for now, so remove it to avoid any confusion

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

We don't have such a list for now, so remove it to avoid any confusion

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.88%. Comparing base (be63721) to head (b7250f6).

Additional details and impacted files

see 38 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21012      +/-   ##
==========================================
- Coverage   69.24%   68.88%   -0.36%     
==========================================
  Files         422      419       -3     
  Lines       34841    34706     -135     
==========================================
- Hits        24124    23908     -216     
- Misses       9318     9372      +54     
- Partials     1399     1426      +27     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be63721...b7250f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.
lgtm, thanks @ahrtr !!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, spzala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants