Update zkVMs #259
Merged
Update zkVMs #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jsign
approved these changes
Dec 30, 2025
| }); | ||
| } | ||
|
|
||
| // FIXME: Remove this if the `sdk.prove()` above checks exit code. |
Collaborator
There was a problem hiding this comment.
Which "exit code" this refers to?
Collaborator
Author
There was a problem hiding this comment.
Ah it's about the execution exit code, I found that when proving with AOT execution, the exit code is not checked after execution (which is checked without AOT), so the sdk.prove doesn't return error even the guest panics (exits w non-zero code). So here we use the sdk.verify to help check the exit code is zero.
Discussed with Jonathan offline and he said they'd try to make the API more consistent, if it's updated and we can remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update zkVMs (all patch version bumped so I put them in the same PR):
v5.2.3→v5.2.4(resolves Updatesp1tov5.2.4#249 )v1.2.0→v1.2.2(resolves Updatepicotov1.2.2#257 )v0.5.1→v0.5.2(resolves Updateairbendertov0.5.2#256 )v0.20.0→v0.20.1(issue not created because the script failed before, but fixed as well in this PR)Misc:
fetch_zkvm_version.sh(previously failed for miden)aotfeature of OpenVMnexusSDK installation script (need to pin some crate manually because missing ofCargo.lock)ereversion to0.0.16