op-challenger: Integrate super node trace provider #18668
+422
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #18668 +/- ##
===========================================
- Coverage 73.54% 66.58% -6.96%
===========================================
Files 189 55 -134
Lines 11244 4031 -7213
===========================================
- Hits 8269 2684 -5585
+ Misses 2831 1203 -1628
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ajsutton
force-pushed
the
aj/integrate-supernode
branch
from
c6d873e to
d04c868
Compare
ajsutton
force-pushed
the
aj/integrate-supernode
branch
from
d04c868 to
88c74ff
Compare
Add a config option to switch to super node.
Interface values are only nil if the type and value are nil - in our case the type is always non-nil so superNodeProvider == nil is always false causing panics.
ajsutton
force-pushed
the
aj/integrate-supernode
branch
from
88c74ff to
16cb91b
Compare
Inphi
approved these changes
Jan 6, 2026
| Usage: "Provider URL for supervisor RPC", | ||
| EnvVars: prefixEnvVars("SUPERVISOR_RPC"), | ||
| SuperRpcFlag = &cli.StringFlag{ | ||
| Name: "super-rpc", |
Contributor
There was a problem hiding this comment.
nit: Although super-rpc here refers to both supervisor and supernode, we might as well change this now to supernode-rpc since that's what we'll be using in the end. Using supernode-rpc will be confusing only to humans outside of proofs, but I expect we'd have fully migrated to using op-supernode for anyone else to care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate the super node trace provider into op-challenger. Since we plan to remove op-supervisor support as soon as all the tests are migrated, this is setup to replace it with a simple config toggle to choose between supervisor and super node. That requires significantly fewer changes to the config/cli validation code which would just be thrown out again when removing op-supervisor support. If needed we can add a hidden CLI flag to set the toggle as well, but there's a pretty good chance the supervisor tests can be updated without needing it.
There's still some places that create a supervisor client and trace provider directly like in op-e2e and vm runner. We'll need to switch them over in follow up PRs.
Metadata
#18524