Skip to content

Conversation

@serpixel
Copy link
Contributor

Description

Windows requires a file handle in order to call Setnonblock. This is a bit redundant in our case given that the implementation does nothing, therefore we just skip the method on windows to avoid the failing build.

  ⨯ release failed after 2m44s                      
    error=
    │ build failed: exit status 1: # github.com/ethereum-optimism/optimism/op-preimage
    │ ../op-preimage/filechan.go:93:26: cannot use fd (variable of type int) as syscall.Handle value in argument to syscall.SetNonblock
    target=windows_amd64_v1

Tests

Additional context

Metadata

@serpixel serpixel requested review from a team as code owners December 23, 2025 00:18
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.49%. Comparing base (722b12f) to head (0689365).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18688      +/-   ##
===========================================
+ Coverage    66.60%   73.49%   +6.89%     
===========================================
  Files          189      189              
  Lines        11244    11244              
===========================================
+ Hits          7489     8264     +775     
+ Misses        3611     2836     -775     
  Partials       144      144              
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (ø)
contracts-bedrock-tests 77.36% <ø> (+10.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@serpixel serpixel added this pull request to the merge queue Dec 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants