Skip to content

Conversation

@pauldowman
Copy link
Contributor

Description

Most of the git submodules use https. But the three newest ones use SSH. They should be consistent. git submodule update won't work for anyone who doesn't have an SSH public key registered with github, which is less common for most contributors than github auth via https.

NOTE! This means everyone will need to do git submodule sync && git submodule update.

Tests

Additional context

Metadata

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (722b12f) to head (a9ca06b).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #18690       +/-   ##
============================================
+ Coverage    66.89%   77.36%   +10.46%     
============================================
  Files          189      134       -55     
  Lines        11244     7213     -4031     
============================================
- Hits          7522     5580     -1942     
+ Misses        3576     1633     -1943     
+ Partials       146        0      -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 77.36% <ø> (+10.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 89 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants