test(contracts): improve OptimismMintableERC20 test coverage #18696
+80
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert focused tests to fuzz tests for broader coverage: - mint: fuzz _to address and _amount - burn: fuzz _from address and _amount - mint/burn notBridge: fuzz _caller address - permit2 transferFrom: fuzz _owner, _to, and _amount - allowance permit2Max: fuzz _owner address
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18696 +/- ##
===========================================
+ Coverage 70.92% 77.37% +6.44%
===========================================
Files 189 134 -55
Lines 11244 7213 -4031
===========================================
- Hits 7975 5581 -2394
+ Misses 3123 1632 -1491
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
JosepBove
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the
OptimismMintableERC20test file by converting focused tests to fuzz tests for broader coverage and adding tests for previously uncovered code paths.Changes:
allowance()non-PERMIT2 branchsupportsInterface()false return casedecimals()andversion()functionsassert()→assertTrue()(Forge convention)Review & Testing Checklist for Human
test_decimals_succeedsassertion of 18 decimals matches howL2Tokenis created inCommonTest.bridgeInitializerSetUp()viacreateStandardL2Token()vm.assume(_owner != _to)in permit2 test prevents self-transfer edge case - is this intentional?)just test-dev --match-path test/universal/OptimismMintableERC20.t.sol -vto verify all 16 tests passRecommended test plan: Run the test suite locally and verify the fuzz tests exercise meaningful value ranges.
Notes
Link to Devin run: https://app.devin.ai/sessions/84c09a1ef33944368652d4d50888283a
Requested by: Ariel Diaz (@aliersh)
Last update: 2025-12-29 03:00 ET