Skip to content

Conversation

@0xiamflux
Copy link
Contributor

Summary

Improves test coverage and documentation for the UpgradeOPChain script, focusing on OPCM V2 upgrade path. It adds fuzzing, input encoding verification, revert case testing, and better documentation.

Changes

Testing

  • Add fuzzing to UpgradeOPChain test
  • Add input encoding verification: Ensures upgrade inputs are correctly encoded before being passed to the OPCM contract from the op-deployer.
  • Add revert cases for setters and tests: Covers error paths for setter functions for the UpgradeOPChain script.
  • Remove extraInstructions in upgradeSuperchain test

Related Issues

#18502

* fix: remove extraInstructions in upgradeSuperchain test

* docs: add cgt extra instruction TODO

* test: add fuzzing to UpgradeOPChain test

* feat: add revert cases for setters and tests

* test: add input encoding verification

* fix: add v2 suffix in upgrade test

* docs: added natspec to upgradeOPChain tests
@maurelian
Copy link
Contributor

/ci authorize cbd0cb2

@maurelian maurelian mentioned this pull request Jan 6, 2026
@0xiamflux 0xiamflux marked this pull request as ready for review January 6, 2026 16:45
@0xiamflux 0xiamflux requested review from a team as code owners January 6, 2026 16:45
@0xiamflux 0xiamflux requested a review from agusduha January 6, 2026 16:45
@0xOneTony
Copy link
Contributor

/ci authorize 98b1e2f

@maurelian maurelian enabled auto-merge January 6, 2026 20:45
@maurelian maurelian added this pull request to the merge queue Jan 6, 2026
Merged via the queue into ethereum-optimism:develop with commit e42ff77 Jan 6, 2026
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants