-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Remove l2oo support #18706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Remove l2oo support #18706
Conversation
Removes legacy L2OutputOracle (L2OO) proposal logic in favor of exclusive DisputeGameFactory (DGF) support. - Flattened logic in driver.go's loop and sendTransaction. - Removed unused waitForL1Head and manual ABI packing functions. - Updated driver_test.go to remove L2OO test vectors and update DGF mocks. - Cleaned up config_test.go to remove legacy requirement checks. This simplifies the proposer architecture as part of the transition to the Fault Proof system. Fixes ethereum-optimism#18620
ajsutton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally. Couple of small details and we should also remove the L2OO flags.
There are some customised chains still using L2OO support which we'll have to work with before we can merge this though.
Co-authored-by: Adrian Sutton <adrian@symphonious.net>
|
Could you also remove the L2OOAddressFlag definition? optimism/op-proposer/flags/flags.go Line 42 in b6635e7
|
Done |
|
/ci authorize c779c9d |
Description
Deprioritized Legacy Proposals: Fully removed
L2OutputOraclelogic from the proposer service.Streamlined Driver: Flattened the
sendTransactionandlooplogic, removing thewaitForL1Headcheck and conditional branching.Refactored Tests: Updated
driver_test.goandconfig_test.goto remove legacy test vectors and modernized mocks to support the unified DGF proposal path.Tests
All
op-proposer/proposer/...tests pass withgo test -v.Verified that the proposer correctly panics or errors if the required
DisputeGameFactoryaddress is missing, preventing misconfiguration.Metadata