Skip to content

feat: migrate from ethers.js to viem #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikhilkumar1612 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: migrate from ethers.js to viem #117

nikhilkumar1612 wants to merge 4 commits into from

Conversation

@nikhilkumar1612
Copy link
Contributor

@nikhilkumar1612 nikhilkumar1612 commented Jul 23, 2024

Description

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@nikhilkumar1612 nikhilkumar1612 mentioned this pull request Jul 23, 2024
Open
@ch4r10t33r
Copy link
Member

ch4r10t33r commented Jul 23, 2024

Thanks for submitting the PR. Pls can you let us know how you tested this?

@nikhilkumar1612
Copy link
Contributor Author

nikhilkumar1612 commented Jul 23, 2024

Thanks for submitting the PR. Pls can you let us know how you tested this?

Hey i have tested my changes individully, but e2e testing is not done. Please provide me api details and sample env.

kanthgithub
kanthgithub reviewed Jul 23, 2024
View reviewed changes
backend/src/utils/common.ts
if(log) log.info('setting maxFeePerGas and maxPriorityFeePerGas as received')
const maxFeePerGas = ethers.utils.parseUnits(response.result.suggestBaseFee, 'gwei')
const fastGasPrice = ethers.utils.parseUnits(response.result.FastGasPrice, 'gwei')
const maxFeePerGas = parseUnits(response.result.suggestBaseFee, 9);
Copy link
Contributor

@kanthgithub kanthgithub Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilkumar1612 create a constant value for gwei and use it allover where parseUnits of viem is called for GWEI conversion

Copy link
Contributor Author

@nikhilkumar1612 nikhilkumar1612 Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilkumar1612 create a constant value for gwei and use it allover where parseUnits of viem is called for GWEI conversion

sure 👍 @kanthgithub

@kanthgithub
Copy link
Contributor

kanthgithub commented Jul 23, 2024

@nikhilkumar1612 please use the latest version of viem. seems the sendTransaction signature changed in latest version
2.17.0 is latest release

@nikhilkumar1612
Copy link
Contributor Author

nikhilkumar1612 commented Jul 23, 2024

@nikhilkumar1612 please use the latest version of viem. seems the sendTransaction signature changed in latest version 2.17.0 is latest release

hey @kanthgithub i can see 2.17.10 is the latest version, please let me know if i have to use 2.17.0 or 2.17.10 ?

@nikhilkumar1612
Copy link
Contributor Author

nikhilkumar1612 commented Jul 26, 2024

hey @kanthgithub are there any further changes that i have to make ?

also please provide a confirm on the version of viem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kanthgithub kanthgithub kanthgithub left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikhilkumar1612 @ch4r10t33r @kanthgithub