Skip to content

Release 05.06.2025 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vignesha22 merged 1 commit into from
Jun 6, 2025
Merged

Release 05.06.2025 #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Changelog
## [4.1.2] - 2025-06-05
- Fetch from coingecko only if coingecko-token-repository records are available else skip calling the api

Comment on lines +2 to +4
Copy link

@coderabbitai coderabbitai bot Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Minor formatting improvements needed.

The changelog entry accurately documents the implemented change. However, there are a few formatting issues to address:

+
 ## [4.1.2] - 2025-06-05
-- Fetch from coingecko only if coingecko-token-repository records are available else skip calling the api
+
+- Fetch from coingecko only if coingecko-token-repository records are available, else skip calling the api
+
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## [4.1.2] - 2025-06-05
- Fetch from coingecko only if coingecko-token-repository records are available else skip calling the api
## [4.1.2] - 2025-06-05
- Fetch from coingecko only if coingecko-token-repository records are available, else skip calling the api
🧰 Tools
🪛 LanguageTool

[uncategorized] ~3-~3: Possible missing comma found.
Context: ... coingecko-token-repository records are available else skip calling the api ## [4.1.1] -...

(AI_HYDRA_LEO_MISSING_COMMA)

🪛 markdownlint-cli2 (0.17.2)

2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above

(MD022, blanks-around-headings)

2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

3-3: Lists should be surrounded by blank lines
null

(MD032, blanks-around-lists)

🤖 Prompt for AI Agents 
In backend/CHANGELOG.md around lines 2 to 4, the changelog entry has minor
formatting issues. Ensure the version header is properly formatted with
consistent spacing and markdown syntax. Also, format the bullet point with
correct capitalization and punctuation for clarity and consistency with other
entries.

## [4.1.1] - 2025-05-24
- Fixed bug of comparing chainId as string for skipping type2 to legacy txn

Expand Down
2 changes: 1 addition & 1 deletion backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "arka",
"version": "4.1.1",
"version": "4.1.2",
"description": "ARKA - (Albanian for Cashier's case) is the first open source Paymaster as a service software",
"type": "module",
"directories": {
Expand Down
4 changes: 4 additions & 0 deletions backend/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ const initializeServer = async (): Promise<void> => {
const getAndSetCoingeckoPrice = async () => {
const records = await coingeckoRepo.findAll();
const tokenIds = records.map(record => record.coinId);
if (tokenIds.length === 0) {
server.log.info('No token ids found in coingecko tokens repository');
return;
}
const coingecko = new CoingeckoService();

const data = await coingecko.fetchPriceByCoinID(tokenIds, server.log);
Expand Down