-
Notifications
You must be signed in to change notification settings - Fork 11
feat: migrate to bun in github workflows #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughCI workflows replace Node.js/npm with Bun: install Bun via oven-sh/setup-bun@v2, run Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying arka with
|
| Latest commit: |
2815b5a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04826b9e.arka-3qg.pages.dev |
| Branch Preview URL: | https://feat-fix-ci-cd.arka-3qg.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/check-package-version.yml (2)
1-35: Improve PR description with migration scope and intent.The PR description currently contains only placeholders. For a migration of this scope, please provide:
- Clear explanation of why Bun was chosen over npm
- List of all workflows being migrated
- Any breaking changes or required updates for developers (e.g., local setup instructions)
- Testing performed to validate Bun/npm compatibility
- Lock file strategy and any required
.gitignoreupdatesWould you like me to help draft a comprehensive PR description that documents the migration scope, rationale, and validation steps?
1-35: Provide detailed PR description documenting migration scope and validation.The PR description currently contains only placeholders, which makes it difficult to understand the context, rationale, and scope of this Bun migration across CI workflows.
Please update the PR description to include:
- Why Bun? Rationale for choosing Bun over npm (performance, features, etc.)
- Scope: List of all workflows being migrated as part of this PR and any future work
- Developer impact: Changes required for local development workflows and setup instructions
- Validation: Testing performed to confirm Bun/npm build compatibility
- Lock file strategy: Whether
bun.lockshould be committed or how it is managed- Breaking changes: Any changes to CI behavior or artifact output
This context is essential for reviewers and future maintainers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/check-package-version.yml(2 hunks).github/workflows/release.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
.github/workflows/check-package-version.yml (2)
30-31: This workflow step correctly aligns with the project's bun-native setup.The backend is already a bun project (as evidenced by the
enginesfield requiring"bun": >=1.0.0"and build scripts usingbun build). The workflow change from npm to bun is the correct implementation, not a risky migration. Thebun.lockfile is committed to version control, ensuring reproducible builds across CI runs. No further action needed.Likely an incorrect or invalid review comment.
30-31: This is a new workflow, not a migration from npm to Bun — the backend has always been Bun-native.The original concern assumes a migration from npm to Bun, but commit 30a872f creates this workflow file for the first time (new file, not modified). The backend
package.jsonhas always specifiedbun build src/index.tsas the build script, notnpm run build. Thebun.lockfile is properly committed to the repository, which is the standard practice for Bun projects (similar to howpackage-lock.jsonis committed for npm projects). The project explicitly requires Bun via"engines": { "bun": ">=1.0.0" }, and all npm scripts already use Bun commands (bun test,bun build, etc.). The workflow correctly runs the build that was already defined inpackage.json, so compatibility concerns do not apply here.
Description
Types of changes
What types of changes does your code introduce?
Further comments (optional)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.