Skip to content

Delay submit the mining transaction to avoid empty blockhash #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
syntrust wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Delay submit the mining transaction to avoid empty blockhash #487

syntrust wants to merge 2 commits into from

Conversation

@syntrust
Copy link
Collaborator

@syntrust syntrust commented Dec 31, 2025

Addressing ethstorage/storage-contracts-v1#28, this PR

  1. Reverts the "using second latest block header to mine" solution introduced in L2 support miner change #293, because it introduced this bug (cause 1)
  2. Hold on to submit the mining tx till the new slot if sampling and proving are done within the current slot.

Tests were done on a low-difficulty storage contract on Sepolia and go-repidsnark, and the new code changes are covered.

@syntrust syntrust mentioned this pull request Dec 31, 2025
Closed
@syntrust syntrust requested review from ping-ke and qzhodl December 31, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ping-ke ping-ke Awaiting requested review from ping-ke

@qzhodl qzhodl Awaiting requested review from qzhodl

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syntrust