forked from sst/opencode
-
Notifications
You must be signed in to change notification settings - Fork 0
Improve compaction: concrete triggers, auto memory writes, effectiveness framing #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charles-cooper
wants to merge
24
commits into
evmts:dev
Choose a base branch
from
charles-cooper:optimize-compaction
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Position reminder at END of prompt for salience. Key elements: - Specific trigger: 'before your final response' - User expectation framing: 'expects to resume where you left off' - Clear skip condition: informational interactions only
- Add IMPORTANT block in system prompts: preserve error messages, file paths, decisions - Add CRITICAL line in compaction prompt: user constraints/preferences must be preserved - Replace vague 'loses detail but gains clarity' with explicit preservation requirements
Lost info = repeating work or wrong directions, not just user expectations
Some models may not generate the files field reliably, causing AI_NoObjectGeneratedError. Making it optional with empty default prevents schema validation failures.
… thresholds - Add 'losing touch with system prompt' as key compaction signal - Add context size guidance: >50% compact more readily, >70% actively seek - Frame high-context compaction with economic rationale (cost + clarity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.agent-files/via structuredfilesfield in schema<context-status>into compaction prompt for model awarenessChanges
compaction.ts- addfilesschema, auto-write to.agent-files/, remove hidden text partprompt.ts- inject context status into compaction system promptcompact.ts- update tool description with quality-based triggerssession/index.tsx- distinguish manual vs auto spinner textcompaction.txt- detailed guidance for summary/continue/files output