remove notebook #170
Merged
remove notebook #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One nice feature of Jupyter notebooks is the ability to run individual cells, regenerating graphs selectively and individually. It would be good to enhance the CLI interface of the script to allow regenerating specific graphs selected via a parameter/flag. |
|
This pull request introduces 14 alerts when merging 169aaf0 into 232ccd6 - view on LGTM.com new alerts:
|
jwasinger
force-pushed
the
remove-notebook
branch
from
175538f to
d766b04
Compare
Contributor
Author
|
LGTM warnings don't represent issues introduced by this PR but rather, previously-uncaught issues with the notebook. |
|
This pull request introduces 14 alerts when merging d766b04 into 232ccd6 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating CI failures while trying to finish #169 and found that the command (https://github.com/ewasm/benchmarking/blob/master/Makefile#L41) to clean metadata from notebook has mysteriously stopped working (metatdata remains embedded in the notebook).
I'm tired of playing wack-a-mole with all these jupyter notebook issues that keep cropping up. This PR turns the notebook into a python script and removes the notebook from the repository.