Use macaddr rather than eui48 and bump dependencies #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like the |
ewilken
reviewed
Mar 12, 2023
Owner
ewilken
left a comment
ewilken
left a comment
There was a problem hiding this comment.
Thanks a lot! LGTM.
Did you test the pairing process with an actual iOS controller after this change?
I'll have a look at what's up with the CI.
ewilken
approved these changes
Mar 12, 2023
Collaborator
Author
I just did the fan example and it worked. Any idea how this could be done in CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up on this tangent because when I ran
cargo checkon main, I saw this warning:I felt like moving to
macaddrwas better than trying to fixeui48given how old abaumhauer/eui48#34 is.Given that part of this was to satisfy
cargo audit, I decided to bump a few dependencies.