Skip to content

feat: use pools for attributes and options #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
costela merged 4 commits into from
Jul 24, 2025
Merged

feat: use pools for attributes and options #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
432827d
perf: use empty struct as context key
costela Jul 19, 2025
c004fbd
feat: switch benchmark to go1.24 loop
costela Jul 19, 2025
69969bd
perf: remove nil check by directly setting spanNameFUnc
costela Jul 19, 2025
9d8e8fc
feat: use pools for attributes and options
costela Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions operation_name_go124.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,9 @@ import (
"strings"
)

// sqlOperationName attempts to get the first 'word' from a given SQL query, which usually
// defaultSpanNameFunc attempts to get the first 'word' from a given SQL query, which usually
// is the operation name (e.g. 'SELECT').
func (t *Tracer) sqlOperationName(stmt string) string {
if t.spanNameFunc != nil {
return t.spanNameFunc(stmt)
}

func defaultSpanNameFunc(stmt string) string {
for word := range strings.FieldsSeq(stmt) {
return strings.ToUpper(word)
}
Expand Down
11 changes: 2 additions & 9 deletions operation_name_legacy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,9 @@ import (
"unicode"
)

// sqlOperationName attempts to get the first 'word' from a given SQL query, which usually
// defaultSpanNameFunc attempts to get the first 'word' from a given SQL query, which usually
// is the operation name (e.g. 'SELECT').
func (t *Tracer) sqlOperationName(stmt string) string {
// If a custom function is provided, use that. Otherwise, fall back to the
// default implementation. This allows users to override the default
// behavior without having to reimplement it.
if t.spanNameFunc != nil {
return t.spanNameFunc(stmt)
}

func defaultSpanNameFunc(stmt string) string {
stmt = strings.TrimSpace(stmt)
end := strings.IndexFunc(stmt, unicode.IsSpace)
if end < 0 && len(stmt) > 0 {
Expand Down
Loading