Save and modify functionality #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: Modifying text files Modifying IES files Adding new files via dragdrop Deleting files Not done: Saving the package
You can now save IPF Files. There's still a lot of QOL tweaks to be made, but modifying the files in the client is now possible.
Minor correction
Dragdropping a file that already exists properly overwrites it now, even if it's the active file. Deleting files no longer causes issues when saving.
Confirmed PNG files are compressed.
Can now insert rows by right clicking the row header.
You can now delete folders with the delete key. Also fixes a bug where it didn't close files upon loading a new one.
Can change the version by clicking on the label.
Owner
|
Thanks for the PR. Could you quickly summarize what the current features are that you added? I think I recall you mentioning that creating new IPF files from scratch isn't working yet, is that correct? Also, I'd appreciate it if you could go over the code once more and adjust it to match the project's general coding conventions, such as using tabs for indentation, using PascalCase for public fields, etc. |
Author
The interface could definitely use a bit of cleanup, and yeah, making a new file from scatch should be an option, but I've been using it a fair bit for my skill PRs (to give myself the removed skills). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the ability to modify and save IPF files so you can change things in the client. It still needs a little bit more work to be a fully fledged editor but it's getting there.