SED-2978 POC: user avatars #778
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vatars # Conflicts: # projects/step-core/src/lib/step-core.module.ts
neogucky
previously approved these changes
Mar 29, 2024
dvladir
requested review from
david-stephan,
lucianbaciu,
lukasz-lepa and
neogucky
lucianbaciu
reviewed
Apr 4, 2024
| height: 100%; | ||
| } | ||
|
|
||
| .user { |
Contributor
There was a problem hiding this comment.
ambigous class name. I'd rather use "user-label", "user-section" or something similar depending on what you display in current-user-avatar
| if (!this._auth.getConf()?.authentication) { | ||
| return ANONYMOUS_COLOR; | ||
| } | ||
| return user?.preferences?.preferences?.[this._avatarColorPreferenceKey]; |
Contributor
There was a problem hiding this comment.
some model issues on ".preferences.preferences"?
maybe should return a default color in case something is undefined, or it's not the case?
lukasz-lepa
previously approved these changes
Apr 5, 2024
neogucky
previously approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.