-
Notifications
You must be signed in to change notification settings - Fork 3
Sed 4357 extend junit tests for automation packages #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sed 4357 extend junit tests for automation packages #560
Conversation
…execution-does-not-work-with-Java-libraries
…omation-package-test-scope # Conflicts: # step-automation-packages/step-automation-packages-controller/src/test/java/step/automation/packages/AutomationPackageManagerEETest.java # step-automation-packages/step-automation-packages-controller/src/test/java/step/automation/packages/AutomationPackageManagerOSTest.java
…50-Extend-automation-package-test-scope
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
pom.xml
Outdated
| </build> | ||
| </profile> | ||
|
|
||
| <!-- This profile should be activated together with AggregatedJacocoReportEnabled to run tests and save the coverage into the aggregated report (mvn clean verify) --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iegorov777 As discussed, I think this should be part of the same profile as AggregatedJacocoReportEnabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-stephan agree.
Finally I replaced all the profiles with the single AggregatedJacocoReportEnabled.
The concept is described in this comment: https://exense.atlassian.net/browse/SED-4357?focusedCommentId=52772
If we are OK with this approach, we can implement the same in Step EE
|
|
||
| @Test | ||
| public void testMissingDescriptor() throws IOException, AutomationPackageReadingException { | ||
| File tempFolder = FileHelper.createTempFolder(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder will be left behind after the test, which is bad practice. It should be cleaned up after the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-stephan fixed
No description provided.