Skip to content

Conversation

@iegorov777
Copy link
Contributor

No description provided.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

pom.xml Outdated
</build>
</profile>

<!-- This profile should be activated together with AggregatedJacocoReportEnabled to run tests and save the coverage into the aggregated report (mvn clean verify) -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iegorov777 As discussed, I think this should be part of the same profile as AggregatedJacocoReportEnabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-stephan agree.
Finally I replaced all the profiles with the single AggregatedJacocoReportEnabled.
The concept is described in this comment: https://exense.atlassian.net/browse/SED-4357?focusedCommentId=52772

If we are OK with this approach, we can implement the same in Step EE


@Test
public void testMissingDescriptor() throws IOException, AutomationPackageReadingException {
File tempFolder = FileHelper.createTempFolder();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder will be left behind after the test, which is bad practice. It should be cleaned up after the test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants