Skip to content

Conversation

@BNAndras
Copy link
Member

@BNAndras BNAndras commented Jan 6, 2026

Related to #2797. Mark as tiny please.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@Cool-Katt Cool-Katt added the x:size/tiny Tiny amount of work label Jan 6, 2026
@Cool-Katt Cool-Katt merged commit 5527423 into exercism:main Jan 6, 2026
9 checks passed
@BNAndras BNAndras deleted the sync-satellite branch January 6, 2026 06:47
@BNAndras
Copy link
Member Author

BNAndras commented Jan 7, 2026

@exercism/javascript
After merging this PR, https://github.com/exercism/javascript/actions/runs/20740558348/job/59546344880 reported a precheck failure indicating amusement-park's package.json doesn't match the package.json at the root of the repo. Running scripts/sync.mjs, I get 164 package.json files that need to be synced because the root package.json has "core-js": "~3.45.1", where the individual exercise package.json files had "core-js": "~3.42.0",.

This discrepancy came from a dependabot PR two months ago that bumped the root package.json core-js version. Should I PR an update to the individual package.json files?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

The "Sync all exercises" action has started running.

@BNAndras
Copy link
Member Author

BNAndras commented Jan 7, 2026

The "Sync all exercises" action has started running.

Uh oh the robots are taking over.

@SleeplessByte
Copy link
Member

SleeplessByte commented Jan 7, 2026

This discrepancy came from a dependabot PR two months ago that bumped the root package.json core-js version. Should I PR an update to the individual package.json files?

@BNAndras yes if you can PR the sync, that'd be great. (just one pr that does all).

We sometimes miss it. When core-js is updated it also needs to be changed in the config file (I think it's the one in babel). Can you update that too before you sync?

https://github.com/exercism/javascript/blob/main/babel.config.js#L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/tiny Tiny amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants