-
Notifications
You must be signed in to change notification settings - Fork 29
feat(cli): support to application-consistent-snapshot #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(cli): support to application-consistent-snapshot #784
Conversation
sauterp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks correct, just to be sure I would recommend doing a quick test before merging, that updates some other field of an instance unrelated to this change to verify that when you don't set the --application-consistent-snapshot that the state of this feature isn't touched. (I guess I would do two tests, one where it's true and one where it's false)
thx @sauterp , I've updated the description with the tests |
Description
INSTANCE
TEMPLATES
SNAPSHOTS
Checklist
(For exoscale contributors)
Testing