Replace alias with prepend 20180607 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w on inherited ActiveRecord models when their parents are cached_enumerations
tsrivishnu
reviewed
Jun 13, 2018
tsrivishnu
left a comment
tsrivishnu
left a comment
There was a problem hiding this comment.
Looks good in general but I'm wondering how to directly access the methods *_without_cache_enumeration.
For example, in previous version, #first_without_cache_enumeration can be called but now it will throw method_missing error, correct? Or, am I missing something?
tsrivishnu
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having an inherited ActiveRecord model it runs into a stack trace to deep when calling 'first'. Using prepend instead of alias_method solves the problem.