[TASK] Move currency translation to a service #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currency conversion is currently very strongly linked to the cart model and the way in which the currency conversion factor is loaded from TypoScript. In order to be able to obtain the conversion factor from other sources, the calculation is carried out by the `CurrencyTranslationService`. This service is instantiated via the `CurrencyTranslationServiceInterface` interface so that a corresponding exchange via DI is possible. The implementation should only be a start and does not yet offer a stable API because the behaviour must remain the same within the published versions. For this reason, the `CurrencyTranslationServiceInterface` is marked as `@internal`. Use is at your own risk! Changes to the service interface must be observed independently in the event of updates! Resolves: #638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currency conversion is currently very strongly linked to the cart model and the way in which the currency conversion factor is loaded from TypoScript.
In order to be able to obtain the conversion factor from other sources, the calculation is carried out by the
CurrencyTranslationService. This service is instantiated via theCurrencyTranslationServiceInterfaceinterface so that a corresponding exchange via DI is possible.The implementation should only be a start and does not yet offer a stable API because the behaviour must remain the same within the published versions. For this reason, the
CurrencyTranslationServiceInterfaceis marked as@internal. Use is at your own risk! Changes to the service interface must be observed independently in the event of updates!Resolves: #638