[BUGFIX] Use ContextualFeedbackServerity in addFlashMessage function #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to better understand the process in the controller, some code blocks have been moved to new private methods. Furthermore, the ENUM ContextualFeedbackSeverity was used directly instead of the serialised array. A method marked as internal is used, but it is not expected that this will change within a major version. However, this makes it much easier to read in the controller. Related: #646
Resolves: #646
extcode
force-pushed
the
646-bug-typo3-exception-when-calling-productcontrolleraddaction
branch
from
e1836df to
e8c93d6
Compare
extcode
deleted the
646-bug-typo3-exception-when-calling-productcontrolleraddaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.