Skip to content

[BUGFIX] Prevent removal of FlexForm settings #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florian-lst wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Prevent removal of FlexForm settings #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions Classes/Updates/SwitchableControllerActionsPluginUpdater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,11 @@ public function performMigration(): bool
$record['list_type'],
$flexForm['switchableControllerActions']
);
$allowedSettings = $this->getAllowedSettingsFromFlexForm($targetListType);

// Remove flexform data which do not exist in flexform of new plugin
foreach ($flexFormData['data'] as $sheetKey => $sheetData) {
foreach ($sheetData['lDEF'] as $settingName => $setting) {
if (!in_array($settingName, $allowedSettings, true)) {
unset($flexFormData['data'][$sheetKey]['lDEF'][$settingName]);
}
if (isset($sheetData['lDEF']['switchableControllerActions'])) {
unset($flexFormData['data'][$sheetKey]['lDEF']['switchableControllerActions']);
}

// Remove empty sheets
Expand Down Expand Up @@ -163,27 +160,6 @@ protected function getTargetListType(string $sourceListType, string $switchableC
return '';
}

protected function getAllowedSettingsFromFlexForm(string $listType): array
{
if (isset($GLOBALS['TCA']['tt_content']['columns']['pi_flexform']['config']['ds'][$listType . ',list']) === false) {
return [];
}

$flexFormFile = $GLOBALS['TCA']['tt_content']['columns']['pi_flexform']['config']['ds'][$listType . ',list'];
$flexFormContent = file_get_contents(GeneralUtility::getFileAbsFileName(substr(trim((string)$flexFormFile), 5)));
$flexFormData = GeneralUtility::xml2array($flexFormContent);

// Iterate each sheet and extract all settings
$settings = [];
foreach ($flexFormData['sheets'] as $sheet) {
foreach ($sheet['ROOT']['el'] as $setting => $tceForms) {
$settings[] = $setting;
}
}

return $settings;
}

/**
* Updates list_type and pi_flexform of the given content element UID
*
Expand Down