Skip to content

Using Rtools40v2 to test bindings on Windows #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ilia-Kosenkov merged 11 commits into from
May 26, 2021
Merged

Using Rtools40v2 to test bindings on Windows #56

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3057c64
Enabling CI on dev branch
Ilia-Kosenkov May 4, 2021
9e2ff31
Disable unmodified jobs
Ilia-Kosenkov May 5, 2021
7281388
Removed rtools hack
Ilia-Kosenkov May 5, 2021
b55e68e
Explicit rtools40v2
Ilia-Kosenkov May 5, 2021
3da397e
Removing system rtools installation
Ilia-Kosenkov May 5, 2021
64ef085
Handling no base rtools installation
Ilia-Kosenkov May 5, 2021
e8c50b6
Testing with reset cashe
Ilia-Kosenkov May 5, 2021
ffd881f
Reversing back
Ilia-Kosenkov May 5, 2021
8347fec
Removing debug infrastructure
Ilia-Kosenkov May 5, 2021
a55515f
Comments
Ilia-Kosenkov May 5, 2021
286b12a
Switching to new rtools version
Ilia-Kosenkov May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:
branches:
- main
- master
workflow_dispatch:

jobs:

Expand Down Expand Up @@ -193,7 +192,7 @@ jobs:
test_windows_rtools:
runs-on: ${{ matrix.config.os }}

name: ${{ matrix.config.os }} (R-${{ matrix.config.r }} rust-${{ matrix.config.rust-version }}) \w RTOOLS
name: ${{ matrix.config.os }} (R-${{ matrix.config.r }} rust-${{ matrix.config.rust-version }}) \w RTOOLSv2

strategy:
fail-fast: false
Expand All @@ -212,7 +211,7 @@ jobs:
steps:

- uses: actions/checkout@v2

- name: Set up R
uses: r-lib/actions/setup-r@v1
with:
Expand Down Expand Up @@ -243,13 +242,10 @@ jobs:
# Rust toolchain is used to determine target architecture
- name: Configure Windows
if: runner.os == 'Windows'
# 1. Configure path to libclang
# 2. Add path to mingw32/mingw64 -- otherwise library is linked to rtools
# 3. Add path to R's i386/x64 -- to solve x86 build/test issue
# 1. Put rtools' mingw on PATH
# 2. Add R's i386/x64 to PATH
run: |
if ($env:RUST_TARGETS -like "*x86_64*") {
<# Amend rtools libgcc_eh.a #>
cp C:\rtools40\mingw64\lib\gcc\x86_64-w64-mingw32\8.3.0\libgcc.a C:\rtools40\mingw64\lib\gcc\x86_64-w64-mingw32\8.3.0\libgcc_eh.a
echo "C:\rtools40\mingw64\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append ;
echo "$(Rscript.exe -e 'cat(normalizePath(R.home()))')\bin\x64" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append ;
}
Expand Down