feat(interface): php_impl_interface macro

[kakserpom]

Implements #590 and #308

[coveralls]

Pull Request Test Coverage Report for Build 21382858121

Details

• 16 of 126 (12.7%) changed or added relevant lines in 8 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.5%) to 34.836%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/internal/class.rs	0	2	0.0%
src/builders/class.rs	3	7	42.86%
src/class.rs	0	4	0.0%
src/builders/module.rs	1	6	16.67%
crates/macros/src/lib.rs	0	8	0.0%
crates/macros/src/interface.rs	5	17	29.41%
crates/macros/src/function.rs	7	26	26.92%
crates/macros/src/impl_interface.rs	0	56	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/builders/class.rs	1	57.82%

Totals
Change from base Build 21373612702:	-0.5%
Covered Lines:	1916
Relevant Lines:	5500

---

💛 - Coveralls

[kakserpom]

@ptondereau @Xenira

Please review/merge.

[kakserpom]

@ptondereau Rebased and green. This one next?

[ptondereau]

Nice first draft.

But let me add some suggestions:

• Can we add a compile-time error if #[php_impl_interface] is used on a non-trait impl?
• Maybe throw a warning if trait methods aren't also in #[php_impl]
• We should add an example in the documentation showing cross-crate interface implementation

[kakserpom]

Can we add a compile-time error if #[php_impl_interface] is used on a non-trait impl?

✅

Maybe throw a warning if trait methods aren't also in #[php_impl]

Now there's no need to define them separately in php_impl.

We should add an example in the documentation showing cross-crate interface implementation

✅

[ptondereau]

I'll do a final review tomorrow but for now LGTM

[ptondereau]

One more things 😅

[kakserpom]

One more things 😅

All done, Mr Colombo, but CI is acting weird

[ptondereau]

One more things 😅

All done, Mr Colombo, but CI is acting weird

thank you!
it seems that GH is having some trouble... Let's wait, and I will merge once feedback from CI is green

[ptondereau]

@kakserpom Maybe you might be interested in this #653

[kakserpom]

@kakserpom Maybe you might be interested in this #653

How is it related?