[prism] Fix extra newline after require kwarg #765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #762
This bit in the line metadata handling looks for
"require"as a DirectPart to determine when we're in a series ofrequirecalls, which we insert a blank line after. This was happening afterrequire:as a kwarg (or hash key etc.) in the Prism implementation because in Ripper, keys would always be a DirectPart of"name:", whereas Prism separately emitted the name and then a colon as two parts.This PR tries to always emit assoc node keys as
"name:"to circumvent this. I don't know if it's my favorite approach in the world (part of me wonders if we should instead have more descriptive token types that aren't justDirectPartfor this), but this is what Ripper does, so I figured I'd keep it simple and just follow that.