Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

Conversation

@GStudiosX2
Copy link
Contributor

@GStudiosX2 GStudiosX2 commented Jun 2, 2024

@GStudiosX2 GStudiosX2 changed the title Implement some features people requested set_timeout, GitHub tree links, paths Jun 2, 2024
@jamiw1
Copy link

jamiw1 commented Jun 2, 2024

all of these features would be amazing

Copy link
Contributor

@Sakura-sx Sakura-sx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested yet but looks promising.

@GStudiosX2
Copy link
Contributor Author

f89xFqz.mp4

Someone made videos with this pr lol
Credit: thebroz on discord

@Jab11n
Copy link

Jab11n commented Jun 3, 2024

this would be good

@jamiw1
Copy link

jamiw1 commented Jun 3, 2024

someone test lua sandboxing

@GStudiosX2
Copy link
Contributor Author

GStudiosX2 commented Jun 3, 2024

The only thing I tested it on is Dingle & on the set_timeout example I added just need it to be tested more

@the-broz
Copy link

the-broz commented Jun 3, 2024

set_timeout seems to use memory and cpu even after closing the website using it. might need to check that.

@GStudiosX2
Copy link
Contributor Author

set_timeout seems to use memory and cpu even after closing the website using it. might need to check that.

Yeah it's a just a simple implementation probably want to store the timeout some where and then abort them all when switching pages

@GStudiosX2 GStudiosX2 changed the title set_timeout, GitHub tree links, paths set_timeout, GitHub tree links, paths and more! Jun 3, 2024
@GStudiosX2
Copy link
Contributor Author

GStudiosX2 commented Jun 3, 2024

Alright think I'm done with this pr now just needs testing

@GStudiosX2
Copy link
Contributor Author

Last for real now

@GStudiosX2
Copy link
Contributor Author

In process of fixing conflicts

@GStudiosX2
Copy link
Contributor Author

GStudiosX2 commented Jun 3, 2024

f89xFqz.mp4
Someone made videos with this pr lol Credit: thebroz on discord

XRecorder_03062024_150505.mp4

Made this with set_timeout and base64 and it's faster because it doesn't have to keep fetching the next frame it already has a all the frames one issue though is it takes a ton of storage and is slow if you have high resolution images it probably could be improved but video support is already in a different pr

@goodzombz
Copy link

this is fire and you are a legend

@GStudiosX2
Copy link
Contributor Author

Someone made actual video support #150

@face-hh
Copy link
Owner

face-hh commented Jun 4, 2024

This part is breaking local paths.

async fn parse_html(mut url: String) -> Result<(Node, Node)> {
    println!("{url}"); // file://C:\Users\Face\Documents\GitHub\webx_github\napture\test
    if let Ok(mut uri) = Url::parse(&url) {
       if let Ok(mut segments) = uri.path_segments_mut() {
           segments.pop_if_empty();
           segments.push("index.html");
       }
       url = uri.into();
    }

    println!("{url}"); // /C:/Users/Face/Documents/GitHub/webx_github/napture/test/index.html

    let html = fetch_file(url).await;

@GStudiosX2
Copy link
Contributor Author

GStudiosX2 commented Jun 4, 2024

Can you test don't have PC ATM

@GStudiosX2
Copy link
Contributor Author

@face-hh

@face-hh
Copy link
Owner

face-hh commented Jun 4, 2024

image
same issue

@face-hh
Copy link
Owner

face-hh commented Jun 4, 2024

The DNS doesn't seem to work on this pull request

@face-hh
Copy link
Owner

face-hh commented Jun 4, 2024

The DNS doesn't seem to work on this pull request

Nevermind, it was my DNS setting

@face-hh
Copy link
Owner

face-hh commented Jun 4, 2024

Everything else seems to work fine

@face-hh face-hh merged commit 83447e9 into face-hh:master Jun 4, 2024
@ghost ghost mentioned this pull request Jun 4, 2024
@GStudiosX2
Copy link
Contributor Author

GStudiosX2 commented Jun 4, 2024

image same issue

Your not meant to put file:/// on windows it's file:// there the fix you added makes it break on Linux now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support data urls in images

7 participants