-
Notifications
You must be signed in to change notification settings - Fork 147
set_timeout, GitHub tree links, paths and more! #121
Conversation
|
all of these features would be amazing |
Sakura-sx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested yet but looks promising.
f89xFqz.mp4Someone made videos with this pr lol |
|
this would be good |
|
someone test lua sandboxing |
|
The only thing I tested it on is Dingle & on the set_timeout example I added just need it to be tested more |
|
set_timeout seems to use memory and cpu even after closing the website using it. might need to check that. |
Yeah it's a just a simple implementation probably want to store the timeout some where and then abort them all when switching pages |
|
Alright think I'm done with this pr now just needs testing |
|
Last for real now |
|
In process of fixing conflicts |
XRecorder_03062024_150505.mp4Made this with set_timeout and base64 and it's faster because it doesn't have to keep fetching the next frame it already has a all the frames one issue though is it takes a ton of storage and is slow if you have high resolution images it probably could be improved but video support is already in a different pr |
… html will display as html)
|
this is fire and you are a legend |
|
Someone made actual video support #150 |
|
This part is breaking local paths. async fn parse_html(mut url: String) -> Result<(Node, Node)> {
println!("{url}"); // file://C:\Users\Face\Documents\GitHub\webx_github\napture\test
if let Ok(mut uri) = Url::parse(&url) {
if let Ok(mut segments) = uri.path_segments_mut() {
segments.pop_if_empty();
segments.push("index.html");
}
url = uri.into();
}
println!("{url}"); // /C:/Users/Face/Documents/GitHub/webx_github/napture/test/index.html
let html = fetch_file(url).await; |
|
Can you test don't have PC ATM |
|
The DNS doesn't seem to work on this pull request |
Nevermind, it was my DNS setting |
|
Everything else seems to work fine |


Uh oh!
There was an error while loading. Please reload this page.