Sync on js thread after animation finished #54877
Open
+365
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89042949. |
facebook-github-bot
force-pushed
the
export-D89042949
branch
from
2280619 to
828714a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff adds synchronizing props to react, through a scheduled commit on the js thread. This is used by animated at the end of the animation, and leverages RSNRU to actually push the update to reactjs. Differential Revision: D89042949
facebook-github-bot
force-pushed
the
export-D89042949
branch
from
828714a to
89aeabc
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff adds synchronizing props to react, through a scheduled commit on the js thread. This is used by animated at the end of the animation, and leverages RSNRU to actually push the update to reactjs. Differential Revision: D89042949
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
facebook-github-bot
force-pushed
the
export-D89042949
branch
from
89aeabc to
842f678
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Summary: This diff adds synchronizing props to react, through a scheduled commit on the js thread. This is used by animated at the end of the animation, and leverages RSNRU to actually push the update to reactjs. Differential Revision: D89042949
added 4 commits
December 12, 2025 09:13
Summary: For the testing purposes, during the development of Animation Backend, we changed the way props are modified from animated, to use the AnimatedProps. As these would currently not benefit c++ Animated, this diff reverts that to use `folly::dynamic` again. Differential Revision: D88743857
Summary: This diff simple extends the tests for AnimationBackend Differential Revision: D85753518
Summary: This diff changes the AnimatedPropsRegistry to also contain updates that go through the synchronous props update fast-path. Differential Revision: D89042934
Summary: This diff adds synchronizing props to react, through a scheduled commit on the js thread. This is used by animated at the end of the animation, and leverages RSNRU to actually push the update to reactjs. Differential Revision: D89042949
facebook-github-bot
force-pushed
the
export-D89042949
branch
from
842f678 to
0102d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds synchronizing props to react, through a scheduled commit on the js thread. This is used by animated at the end of the animation, and leverages RSNRU to actually push the update to reactjs.
Differential Revision: D89042949