-
Notifications
You must be signed in to change notification settings - Fork 336
Add sl pr get command and ISL PR Dashboard #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ntation - Add Graphite stack comment parser to detect and parse PR stacks managed by Graphite, extracting PR numbers, current position, and base branch - Replace Netlify auth provider with custom Cloudflare Pages Functions for GitHub OAuth flow, reading token from URL hash after redirect - Add support for reviews.qlax.dev hostname in login dialog - Update GraphQL query to include comment body for Graphite parsing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace GitHub Pages deployment with Cloudflare Pages using wrangler-action - Trigger on push to main when reviewstack files change (instead of schedule) - Keep existing build process with codegen, eslint, and tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove custom build container that doesn't exist in fork - Use actions/setup-node@v4 with Node 20 and yarn caching - Update actions/checkout to v4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Detect generated files via .gitattributes linguist-generated patterns, @generated/@partially-generated tags in file content, and default patterns (lock files, .min.js, etc.) - Show "X sig" counter next to +/- counts with explanatory tooltip - Label generated files in diff header with "Generated" badge - Auto-collapse generated files in the diff view - Fix: Move fileGeneratedStatus into waitForAll preload block to prevent re-rendering issues (per TODO T122242329) - Fix: Calculate SLOC using per-file diff lines instead of entire file content for accurate significant line counts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary: Test Plan:
Add `sl pr get` CLI command to pull entire PR stacks from GitHub by parsing the Sapling stack footer in PR descriptions. The command supports --goto to checkout the target commit and --downstack to only fetch from trunk to the target PR. Add ISL PR Dashboard in the left drawer showing all open PRs from the last 30 days, grouped by stacks. Each stack shows PRs in order with one-click "Pull" buttons to fetch stacks via `sl pr get`. Features: - sl pr get <PR> - Import full stack based on PR body footer - sl pr get <PR> --goto - Import and checkout target - sl pr get <PR> --downstack - Only fetch trunk→target - PR Dashboard shows all open PRs grouped by stacks - Keyboard shortcut Cmd+, to toggle left drawer Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Hi @Lennix! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Add
sl pr getCLI command to pull entire PR stacks from GitHub byparsing the Sapling stack footer in PR descriptions. The command supports
--goto to checkout the target commit and --downstack to only fetch
from trunk to the target PR.
Add ISL PR Dashboard in the left drawer showing all open PRs from the
last 30 days, grouped by stacks. Each stack shows PRs in order with
one-click "Pull" buttons to fetch stacks via
sl pr get.Features:
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Stack created with Sapling. Best reviewed with ReviewStack.