Add collapsible stacks, PR Dashboard enhancements, and ComparisonView file click #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation - Add Graphite stack comment parser to detect and parse PR stacks managed by Graphite, extracting PR numbers, current position, and base branch - Replace Netlify auth provider with custom Cloudflare Pages Functions for GitHub OAuth flow, reading token from URL hash after redirect - Add support for reviews.qlax.dev hostname in login dialog - Update GraphQL query to include comment body for Graphite parsing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace GitHub Pages deployment with Cloudflare Pages using wrangler-action - Trigger on push to main when reviewstack files change (instead of schedule) - Keep existing build process with codegen, eslint, and tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove custom build container that doesn't exist in fork - Use actions/setup-node@v4 with Node 20 and yarn caching - Update actions/checkout to v4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Detect generated files via .gitattributes linguist-generated patterns, @generated/@partially-generated tags in file content, and default patterns (lock files, .min.js, etc.) - Show "X sig" counter next to +/- counts with explanatory tooltip - Label generated files in diff header with "Generated" badge - Auto-collapse generated files in the diff view - Fix: Move fileGeneratedStatus into waitForAll preload block to prevent re-rendering issues (per TODO T122242329) - Fix: Calculate SLOC using per-file diff lines instead of entire file content for accurate significant line counts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary: Test Plan:
Add `sl pr get` CLI command to pull entire PR stacks from GitHub by parsing the Sapling stack footer in PR descriptions. The command supports --goto to checkout the target commit and --downstack to only fetch from trunk to the target PR. Add ISL PR Dashboard in the left drawer showing all open PRs from the last 30 days, grouped by stacks. Each stack shows PRs in order with one-click "Pull" buttons to fetch stacks via `sl pr get`. Features: - sl pr get <PR> - Import full stack based on PR body footer - sl pr get <PR> --goto - Import and checkout target - sl pr get <PR> --downstack - Only fetch trunk→target - PR Dashboard shows all open PRs grouped by stacks - Keyboard shortcut Cmd+, to toggle left drawer Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add a new config option `github.submit-to-upstream` (default: true) that controls whether `sl pr submit` creates PRs against the upstream repository when working from a fork, or against the fork itself. When set to false, PRs will be created on your fork instead of the upstream repository. This is useful when you want to create PRs within your own fork for testing or other purposes. Usage: [github] submit-to-upstream = false Or via command line: sl --config github.submit-to-upstream=false pr submit Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add github.submit-to-upstream config option
- Add author { login, avatarUrl } to YourPullRequestsQuery and YourPullRequestsWithoutMergeQueueQuery
- Add viewer { login } to get current authenticated user
- Pass author info through githubCodeReviewProvider to DiffSummary
- Update CodeReviewProvider interface to pass currentUser in onChangeDiffSummaries callback
- Add currentGitHubUser atom to track the authenticated user on the client
- Add mainAuthor and mainAuthorAvatarUrl to PRStack type
- Add isExternalCommitByDiffId atom to detect commits from other authors
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… file click Collapsible stacks: - Add collapse/expand button to StackActions for stacks with children - Add CollapseAllStacksButton to TopBar for bulk collapse/expand - Filter collapsed commits from CommitTreeList view - Store collapsed state in localStorage for persistence External commit styling: - Add useLineColor prop to RenderDag for custom line colors - Show external commits (from other authors) with gray line color PR Dashboard enhancements: - Add hide/show functionality for stacks with localStorage persistence - Add custom labels with double-click to edit - Display author avatar on stack cards - Add "View changes" button on PR rows to open ComparisonView - Style external stacks with distinct border and background ComparisonView file click: - Add scrollToFile support to ComparisonView - Click on changed file opens ComparisonView and scrolls to that file - Falls back to platform.openFile when no comparison available Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Hi @Lennix! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapsible stacks:
External commit styling:
PR Dashboard enhancements:
ComparisonView file click:
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Stack created with Sapling. Best reviewed with ReviewStack.