Push artifacts to ecr #87
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR; This PR introduces pushing images directly to AWS Marketplace ECR, bypassing GHCR.
It ensures the media-types and manifests follow the Docker image and manifest format that Marketplace prefers (rather than OCI). Additionally, we're now pushing a multi-arch image; so Marketplace users have more options to run Kpow on machines (or K8s nodes) running on ARM platforms without emulation.
Before:
Our release process would require an engineer manually pulling the
linux/amd64image from GHCR, tagging it for ECR and then pushing the image.This was susceptible to failure, and also introduces a vector for human error, as I've experienced (caused) myself; the crux being how the local Docker installation is configured (particularly the use of
containerd) can break the manual release process.Now:
release.ymlwill bypass GitHub Container Registry and instead push images directly to ECR with the correct tag, ready for the change request to release a new version on the Marketplace console.We now bypass the need for having hidden settings configured correctly and avoid pesky manual sequencing.
Changes:
deploy_aws_marketplace.shbash script with correct flags set to produce docker media types and manifest.release_aws_only.ymlto bypass GHCR and push directly to Marketplace ECRrelease.ymldocker buildxpushes multi-architecture manifests to ECR