Admin: Fix theme support. #284
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
afragen
reviewed
Oct 4, 2025
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
…ctivation. Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
…ection. Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
costdev
force-pushed
the
fix_theme_support_for_admin
branch
from
756f8ac to
5fa83b8
Compare
Member
Author
|
Note: The force-push was just a rebase on |
Signed-off-by: Andy Fragen <andy@thefragens.com>
Ipstenu
approved these changes
Oct 27, 2025
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
afragen
reviewed
Nov 7, 2025
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Member
Author
|
Setting to |
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
costdev
commented
Nov 8, 2025
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com> Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
otherwise $theme->exists() fails Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Contributor
costdev
commented
Nov 16, 2025
|
|
||
| $did = $plugin['_fair']['id']; | ||
| $plugin['slug'] = esc_attr( $plugin['slug'] . '-' . str_replace( ':', '--', $did ) ); | ||
| $did = $item->_fair['id']; |
Member
Author
There was a problem hiding this comment.
Noting for myself when I'm next at my PC:
- Previously, we were setting this to
$plugin['_fair']['id']. - Now we're setting this to
$item->_fair['id'].
Are we sure that $item is an object for both plugins and themes?
If no issues exist, why did the previous array syntax work for plugins without issue - or did it?
Signed-off-by: Andy Fragen <andy@thefragens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've mostly been testing with plugins up until now. As a result, some of our features either don't support themes at all, or don't handle the differences between plugins and themes.
I used a test theme,
did:plc:fbiuevja7wpvkgkh4zcswe4r, to step through admin-based theme handling.This PR:
is_fair_plugin()tois_fair_package().rename_source_selectionsupport to themes so a theme is also installed under the correct directory name.preview_url)authorproperty for themes (yep, plugins and themes have different shapes).Reviewers
Blocked by structural changes made in #277. I'd suggest not to review this PR until that's been merged and this PR is rebased onmain. However, if you really want to review it, then you're looking at "Rename is_fair_plugin() to is_fair_package()." (070b72b) onwards.Update: #277 is merged. Go ahead and review!
Testers
You can go ahead and test this PR either locally, or in the Playground link below. Note that modal-based interactions may not work correctly in Playground, which is a Playground issue.
You can test using this DID:
did:plc:fbiuevja7wpvkgkh4zcswe4r