Skip to content

fix: conditionally include the keys category, mutable_content and content-available in aps payload #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrenchGithubUser merged 1 commit into from
Jan 21, 2026
Merged

fix: conditionally include the keys category, mutable_content and content-available in aps payload #205

FrenchGithubUser merged 1 commit into from
Jan 21, 2026

Conversation

@FrenchGithubUser
Copy link
Contributor

@FrenchGithubUser FrenchGithubUser commented Jan 20, 2026

No description provided.

@FrenchGithubUser FrenchGithubUser requested a review from a team as a code owner January 20, 2026 16:22
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-aps-category branch 2 times, most recently from 11a8279 to 6ae0463 Compare January 20, 2026 16:27
@codecov
Copy link

codecov bot commented Jan 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (8e85e0b) to head (c2896b6).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pusher.rs 76.66% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   90.83%   90.17%   -0.67%     
==========================================
  Files           9        9              
  Lines         513      529      +16     
==========================================
+ Hits          466      477      +11     
- Misses         47       52       +5
Files with missing lines Coverage Δ
src/models.rs 96.93% <ø> (ø)
src/pusher.rs 96.29% <76.66%> (-2.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e85e0b...c2896b6. Read the comment docs.

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-aps-category branch 4 times, most recently from 691e296 to 23db4f0 Compare January 21, 2026 09:20
@FrenchGithubUser FrenchGithubUser changed the title fix: fcm error when category is null or unknown string fix: conditionally include the keys category and content-available in aps payload Jan 21, 2026
RasmusRendal
RasmusRendal requested changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@RasmusRendal RasmusRendal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I noticed.

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-aps-category branch from 23db4f0 to 049f68f Compare January 21, 2026 12:59
@FrenchGithubUser
fix: conditionally include the keys category, mutable_content and
c2896b6 
`content-available` in aps payload

if simply set to null, they would create an error for iOS notifications.
they are optional keys, but not nullable
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/fix-aps-category branch from 049f68f to c2896b6 Compare January 21, 2026 13:01
@FrenchGithubUser FrenchGithubUser changed the title fix: conditionally include the keys category and content-available in aps payload fix: conditionally include the keys category, mutable_content and content-available in aps payload Jan 21, 2026
@FrenchGithubUser FrenchGithubUser merged commit c2896b6 into main Jan 21, 2026
4 of 5 checks passed
@FrenchGithubUser FrenchGithubUser deleted the thomast/fix-aps-category branch January 21, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RasmusRendal RasmusRendal RasmusRendal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FrenchGithubUser @RasmusRendal