Skip to content

Conversation

@rfdougherty
Copy link

Description

The data harvesting notebook was not working for me so I simplified the logic and put into a simple shell script (update_data.sh). I also separated out the version update code into update_versions.sh. The existing update code included an nltk dependency that was not accounted for in pyproject.toml, so I added that. It is only needed to update the data, so could possibly be separated into a dev dependency.

Note that I also removed setup.py and setup.cfg as they are not used (given pyproject.toml) and could create confusion.

Fixes # (issue)

Data harvesting.

Type of change

Please delete options that are not relevant.

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • [ X] Requires a documentation revision

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • run update_data.sh
  • run update_versions.sh

Test Configuration

  • Library version: nltk 3.9.2, requests 2.32.5
  • OS: MacOS and Linux
  • Toolchain: python 3.12.3 and 3.14.0

Checklist

  • My PR is for one issue, rather than for multiple unrelated fixes.
  • My code follows the style guidelines of this project. I have applied a Linter (recommended: Pycharm's code formatter) to make my whitespace consistent with the rest of the project. NOTE: I don't use pycharm, but I ran black (default config) on the files that I modified.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes NOTE: tests fail on main due to four missing files from VCS. My changes don't add any additional failures.
  • [NA] Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I add third party dependencies only when necessary. If I changed the requirements, it changes in pyproject.toml
  • [NA] If I introduced a new feature, I documented it ideally in the README examples so that people will know how to use it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic subsumed in the shell script.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic subsumed in the shell script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant